Skip to content

feat(execute): adding sendStdIn to devbox exec #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dines-rl wants to merge 1 commit into
base: next
Choose a base branch
from
Open

feat(execute): adding sendStdIn to devbox exec #647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions src/objects/execution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,21 +30,20 @@ export class Execution {
}
}

// Doesn't work as expected, the execution is killed when the stdin is sent.
// /**
// * Send input to the execution's stdin.
// *
// * @param input - The input to send
// * @param options - Request options
// */
// async sendStdIn(input: string, options?: Core.RequestOptions): Promise<void> {
// await this.client.devboxes.executions.sendStdIn(
// this._devboxId,
// this._executionId,
// { text: input },
// options,
// );
// }
/**
* Send input to the execution's stdin.
*
* @param input - The input to send
* @param options - Request options
*/
async sendStdIn(input: string, options?: Core.RequestOptions): Promise<void> {
await this.client.devboxes.executions.sendStdIn(
this._devboxId,
this._executionId,
{ text: input },
options,
);
}

/**
* Wait for the execution to complete and return the result.
Expand Down
10 changes: 3 additions & 7 deletions tests/smoketests/object-oriented/execution.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ describe('smoketest: object-oriented execution', () => {
}
});

test.skip('start execution with stdin enabled', async () => {
test('start execution with stdin enabled', async () => {
expect(devbox).toBeDefined();
execution = await devbox.cmd.execAsync({
command: 'cat',
Expand All @@ -101,14 +101,10 @@ describe('smoketest: object-oriented execution', () => {
expect((await execution.getState()).status).toBe('running');
});

test.skip('send input to execution', async () => {
test('send input to execution', async () => {
expect(execution).toBeDefined();
expect((await execution.getState()).status).toBe('running');
try {
//await execution.sendStdIn('Hello from stdin!\n');
} catch (error) {
console.error('Error sending input to execution:', error);
}
await execution.sendStdIn('Hello from stdin!\n');

// Wait a bit for the input to be processed
await new Promise((resolve) => setTimeout(resolve, 1000));
Expand Down
Loading