Skip to content

feat(app): Use a new API to pre-cache messages in bulk#931

Draft
tadzik wants to merge 3 commits intomasterfrom
tadzik/bulk-message-downloads
Draft

feat(app): Use a new API to pre-cache messages in bulk#931
tadzik wants to merge 3 commits intomasterfrom
tadzik/bulk-message-downloads

Conversation

@tadzik
Copy link
Contributor

@tadzik tadzik commented Mar 16, 2021

Needs to be similarly adopted in the SearchService.

);
}

//return Promise.allSettled(messagePromises);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure yet if we'd actually prefer allSettled() here or not, but it doesn't compile under our current setup so far anyway ;) If we go for it, we might need a polyfill to make it work on ancient browsers too.

@tadzik tadzik force-pushed the tadzik/bulk-message-downloads branch from 735ebe1 to 6a39311 Compare March 16, 2021 16:02
@tadzik tadzik force-pushed the tadzik/bulk-message-downloads branch from 6a39311 to 797f41f Compare March 17, 2021 16:25
Copy link
Contributor

@gtandersen gtandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @tadzik!

@castaway castaway self-assigned this Sep 21, 2021
Copy link
Contributor

@castaway castaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires #972 to be updated/deployed first


}

const bulkemailendpiont = requesturl.match(/\/rest\/v1\/email\/download\/([0-9,]+)/);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"endpiont"? - typo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments