Conversation
javmorcas
left a comment
javmorcas
left a comment
There was a problem hiding this comment.
Initial review for C++ Classic
perftest_qos_profiles.xml
Outdated
| <resource_limits> | ||
| <max_samples>10</max_samples> | ||
| <initial_samples>1</initial_samples> | ||
| <max_samples_per_instance>1</max_samples_per_instance> |
srcIdl/perftest.idl
Outdated
| @optional unsigned long long min; | ||
| @optional unsigned long long max; | ||
| @optional unsigned long long h50; | ||
| @optional unsigned long long h90; | ||
| @optional unsigned long long h99; | ||
| @optional unsigned long long h9999; | ||
| @optional unsigned long long h999999; |
srcIdl/perftest.idl
Outdated
| @optional unsigned long long packets; | ||
| @optional unsigned long long packetsS; |
There was a problem hiding this comment.
Change these to unsigned long
There was a problem hiding this comment.
Lets call them:
packets
packetsPerSecond
packetsAverage
mbps
mbpsAverage
lostPackets
lostPacketsPercent
There was a problem hiding this comment.
ok, but in perftest_publisher.cpp, packets and packetsPerSecond are unsigned long long data types
srcIdl/perftest.idl
Outdated
| @optional perftestLatencyInfo pLatencyInfo; | ||
| @optional perftestThroughputInfo pThroughputInfo; | ||
| @optional double outputCpu; | ||
| }; No newline at end of file |
There was a problem hiding this comment.
Add a new line at the end of the file.
srcIdl/perftest.idl
Outdated
| @optional double packetsAve; | ||
| @optional double mbps; | ||
| @optional double mbpsAve; | ||
| @optional unsigned long long lost; |
srcCpp/perftest_publisher.cxx
Outdated
| IMessagingWriter *_writer; | ||
| ParameterManager *_PM; | ||
| PerftestPrinter *_printer; | ||
| LatencyInfo _latInfo; |
srcCpp/perftest_publisher.cxx
Outdated
| _PM = &PM; | ||
| _printer = printer; | ||
|
|
||
| _latInfo.dataLength = _printer->_dataLength; |
There was a problem hiding this comment.
I think you can use last_data_length instead of asking the _printer for the datalen.
There was a problem hiding this comment.
It feels weird asking an structure for a member that you are going to later set in the same structure
There was a problem hiding this comment.
ok, now it's _latencyInfo.dataLength = last_data_length
srcCpp/RTIDDSImpl.h
Outdated
| DDSDomainParticipant *participant; | ||
| DDSPublisher *publisher; | ||
| DDSTopic *topic; | ||
| perftestInfoDataWriter *ptInfoWriter; |
srcCpp/RTIDDSImpl.h
Outdated
| DDSPublisher *publisher; | ||
| DDSTopic *topic; | ||
| perftestInfoDataWriter *ptInfoWriter; | ||
| perftestInfo *ptInfo; |
| DDS_PublisherQos publisherQos; | ||
| DDS_DataWriterQos dwQos; | ||
|
|
||
| #ifndef RTI_MICRO |
There was a problem hiding this comment.
Can we check what is the behavior when using micro? We might need to make this differently.
2 participants
This pull request is coming from the issue #280