TKL/Full Size layouts, and a few additions to layout()#96
Open
ogaskell wants to merge 6 commits intorsheldiii:masterfrom
Open
TKL/Full Size layouts, and a few additions to layout()#96ogaskell wants to merge 6 commits intorsheldiii:masterfrom
ogaskell wants to merge 6 commits intorsheldiii:masterfrom
Conversation
Legends still need tweaking as they overrun a lot of keys, and the profile is completely wrong as it seems to be doing 1-2-3-4-4-5 instead of 1-1-2-3-4-4.
This allows the size of legends to be modified. For example, on the TKL layout, many of the nav key's legends are too long to fit on a 1u key with the standard 6 font size, so the legend_sizes allows a change of this. The array specifies differences from the default, so that if the default is adjusted the changed font sizes will be too. For example, +2 means a 2 unit larger legend, 0 means default and -1 means 1 unit smaller.
…ken from the default 60%)
Not sure how to do vertical keys using layout(), so they've been replaced by 2 keys with the same legend.
jonathan-dove
approved these changes
Feb 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds TKL and Full Size layouts.
However, there were a few things than the existing layout function didn't include that were necessary for TKL and Full Size layouts.
legend()-legend_sizes. This argument takes a 2d array, in the same format as the legend and keysize arrays, which specifies how much larger or smaller than default each key's legend should be. Since users may specify their own legend size, it specifies a difference from the default, so +1 increases size by one, 0 leaves a key as default and -1 decreases size by one.vertical_sizes, in the same format aslegend_sizeswhich specifies the vertical size of caps in units. On the row below a vertical cap, a gap must be added to the sizes array since currently, this isn't done automatically.Both of these options have default values, so existing layouts require no modification, and the options can be safely left unset.
Currently, it only works with SA and Cherry profiles. Whatever calculates the row numbers doesn't seem to be able to handle full 6-row layouts. Cherry and SA are working since I set
row_sculpting_offset = -1. DCS and OEM just use the wrong rows, giving a sculpt that's completely wrong, G20 and HiPro give a similar result with just a weird sculpt, and no value ofrow_sculpting_offsetseems to fix these. DSA just throws about 3600 warnings. If anyone could shed some light on how the row system works I could probably try and find a fix.