Fix misleading extrapolation time in buffer_core (#832)#896
Open
selimrecep wants to merge 1 commit intoros2:rollingfrom
Open
Fix misleading extrapolation time in buffer_core (#832)#896selimrecep wants to merge 1 commit intoros2:rollingfrom
selimrecep wants to merge 1 commit intoros2:rollingfrom
Conversation
Author
|
IMHO TF2 error detection logic should be more path-aware in general, but I just wanted to focus on this specific bug for now. |
polortiz4
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue where extrapolation errors incorrectly prioritize metadata gathered during the initial source-to-root traversal (Phase 1). By comparing timestamps from both traversal phases, the error now correctly reports the 'latest data' time for the specific link on the requested transform path.
Verification
Reproduced with the script in #832:
Fixes #832