Took into account of the reference of unmanaged instances#217
Open
CihatAltiparmak wants to merge 1 commit intoros:rollingfrom
Open
Took into account of the reference of unmanaged instances#217CihatAltiparmak wants to merge 1 commit intoros:rollingfrom
CihatAltiparmak wants to merge 1 commit intoros:rollingfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adresses : #218
I have increased
plugin_ref_count_even when unmanaged instances is created.plugin_ref_count_is only changed insideonPluginDeletionfunction andcreateRawInstance.onPluginDeletionis not executed for unmanaged raw instances. Thus, when plugin loader is deleted, shared library is not unloaded. In main branch, it directly unloads library in case onlycreateUnmanagedInstancemethod is used as seen in the example in addressed issue.I have also debugged with valgrind and it has below results.
My PR : https://gist.githubusercontent.com/DarkusAlphaHydranoid/7bde368143c6844ec427159e300cb2fc/raw/0ccecc5e9716fd85d315fc970c9724f96231424f/valgrind_log_class_loader_pr_217.txt
Your main branch: https://gist.githubusercontent.com/DarkusAlphaHydranoid/7bde368143c6844ec427159e300cb2fc/raw/0ccecc5e9716fd85d315fc970c9724f96231424f/valgrind_log_class_loader_commit_464fd14.txt
Looks like my branch has less memory leak.