Improve warning message when unloading a library still in use.#118
Open
nuclearsandwich wants to merge 2 commits intorollingfrom
Open
Improve warning message when unloading a library still in use.#118nuclearsandwich wants to merge 2 commits intorollingfrom
nuclearsandwich wants to merge 2 commits intorollingfrom
Conversation
- include library name - nicer formatting
nuclearsandwich
changed the title
Contributor
|
@nuclearsandwich shall we close this? |
tylerjw
reviewed
Jun 12, 2022
Comment on lines
+153
to
+157
| CONSOLE_BRIDGE_logWarn("class_loader.ClassLoader: SEVERE WARNING!!!\n" | ||
| "Attempting to unload %s\n" | ||
| "while objects created by this library still exist in the heap!\n" | ||
| "You should delete your objects before destroying the ClassLoader. " | ||
| "The library will NOT be unloaded.", library_path_.c_str()); |
Contributor
There was a problem hiding this comment.
In most cases is this a side-affect of the ClassLoader object going out of scope and being destroyed while the plugin(s) it has loaded are still in scope?
Would it be helpful to add this to the error message?
Please verify that the lifetime of the ClassLoader for {} is at least as long as the lifetime of all plugins loaded by that ClassLoader.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port #108 to ROS 2. PR open for CI.