Skip to content

[eve7] Correct main color change update in REveDigitSet #21185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alja wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −33
Open

[eve7] Correct main color change update in REveDigitSet #21185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80d24fe
Remove old TEve funcs and whitespace changes.
osschar Oct 30, 2025
8221fcc
Add necessary stamps when updating the main color in fSingleColor mode.
alja Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion graf3d/eve7/inc/ROOT/REveDigitSet.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,6 @@ public:

void NewShapePicked(int shapeId, Int_t selectionId, bool multi);


bool RequiresExtraSelectionData() const override { return GetAlwaysSecSelect(); };
void FillExtraSelectionData(nlohmann::json& j, const std::set<int>& secondary_idcs) const override;

Expand Down
6 changes: 0 additions & 6 deletions graf3d/eve7/inc/ROOT/REveSecondarySelectable.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@ protected:
SelectionSet_t fSelectedSet; // Selected indices.
SelectionSet_t fHighlightedSet; // Highlighted indices.

// XXXX
// void ProcessGLSelectionInternal(TGLSelectRecord& rec, SelectionSet_t& sset);

public:
REveSecondarySelectable() = default;
virtual ~REveSecondarySelectable() {}
Expand All @@ -48,9 +45,6 @@ public:

SelectionSet_t &RefSelectedSet() { return fSelectedSet; }
SelectionSet_t &RefHighlightedSet() { return fHighlightedSet; }

// XXXX
// void ProcessGLSelection(TGLSelectRecord& rec);
};

} // namespace Experimental
Expand Down
2 changes: 0 additions & 2 deletions graf3d/eve7/inc/ROOT/REveViewer.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,6 @@ protected:
Float_t fBrightness;
Bool_t fUseLightColorSet;

void HandleTooltip();

public:
REveViewerList(const std::string &n="REveViewerList", const std::string &t="");
~REveViewerList() override;
Expand Down
1 change: 1 addition & 0 deletions graf3d/eve7/src/REveDigitSet.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ void REveDigitSet::SetMainColor(Color_t color)
if (fSingleColor)
{
REveElement::SetMainColor(color);
StampObjProps();
}
else if (fFrame)
{
Expand Down
1 change: 0 additions & 1 deletion graf3d/eve7/src/REveSelection.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,7 +709,6 @@ Int_t REveSelection::WriteCoreJson(nlohmann::json &j, Int_t /* rnr_offset */)
}
rec["implied"] = imp;


if (i.first->RequiresExtraSelectionData()) {
i.first->FillExtraSelectionData(rec["extra"], sec);
}
Expand Down
23 changes: 0 additions & 23 deletions graf3d/eve7/src/REveViewer.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,29 +410,6 @@ void REveViewerList::SceneDestructing(REveScene* scene)
}
}

////////////////////////////////////////////////////////////////////////////////
/// Show / hide tooltip for various MouseOver events.
/// Must be called from slots where sender is TGLEventHandler.

void REveViewerList::HandleTooltip()
{
if (fShowTooltip)
{
// TGLViewer *glw = dynamic_cast<TGLViewer*>((TQObject*) gTQSender);
// TGLEventHandler *glh = (TGLEventHandler*) glw->GetEventHandler();
// if (REX::gEve->GetHighlight()->NumChildren() == 1)
// {
// TString title(REX::gEve->GetHighlight()->FirstChild()->GetHighlightTooltip());
// if ( ! title.IsNull())
// glh->TriggerTooltip(title);
// }
// else
// {
// glh->RemoveTooltip();
// }
}
}

////////////////////////////////////////////////////////////////////////////////
/// Set color brightness.

Expand Down
Loading