[cling] Adapt and move closer to clang-repl autocomplete machinery#21182
Draft
devajithvs wants to merge 6 commits intoroot-project:masterfrom
Draft
[cling] Adapt and move closer to clang-repl autocomplete machinery#21182devajithvs wants to merge 6 commits intoroot-project:masterfrom
devajithvs wants to merge 6 commits intoroot-project:masterfrom
Conversation
Autocomplete in cling was broken after root-project@9cdffe0 since cling did autocomplete a bit differently from clang-repl
This will help revert one of our LLVM patches that was added when upgrading to LLVM20
This reverts commit 94bea4b.
Test Results 3 files + 3 3 suites +3 13h 3m 14s ⏱️ + 13h 3m 14s For more details on these failures, see this check. Results for commit 0465e0c. ± Comparison against base commit 7e8e273. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
This is a draft PR:
Autocomplete in cling was broken after 9cdffe0 since cling does autocomplete a bit differently from clang-repl
This will also help us get rid of an LLVM patch that was introduced in the update to LLVM20.
Changes or fixes:
Checklist:
This PR fixes #