Move ROOT ML data loader to tree#21137
Open
vepadulano wants to merge 1 commit intoroot-project:masterfrom
Open
Move ROOT ML data loader to tree#21137vepadulano wants to merge 1 commit intoroot-project:masterfrom
vepadulano wants to merge 1 commit intoroot-project:masterfrom
Conversation
vepadulano
requested review from
bellenot,
couet,
dpiparo,
guitargeek,
lmoneta and
pcanal
as code owners
vepadulano
force-pushed
the
dataloader-mv
branch
2 times, most recently
from
19bbbef to
d445f27
Compare
Test Results 22 files + 22 22 suites +22 3d 15h 59m 40s ⏱️ + 3d 15h 59m 40s Results for commit 3b88d38. ± Comparison against base commit 7e8e273. ♻️ This comment has been updated with latest results. |
pcanal
reviewed
Feb 4, 2026
vepadulano
force-pushed
the
dataloader-mv
branch
from
d445f27 to
7827d88
Compare
vepadulano
force-pushed
the
dataloader-mv
branch
7 times, most recently
from
2ffb49b to
efe07b4
Compare
vepadulano
force-pushed
the
dataloader-mv
branch
from
efe07b4 to
358b2ba
Compare
siliataider
reviewed
Feb 6, 2026
vepadulano
force-pushed
the
dataloader-mv
branch
from
358b2ba to
fa41ec4
Compare
The native ROOT data loading for ML training functionality is related to IO and processing of structured data. It only depends on the ROOTDataFrame component. As such, the following decisions have been made for this part of the codebase: - C++ code - It is meant for internal use only - It is hosted in tree/ml in the repository - It is written in the ROOT[::Experimental]::Internal::ML namespace - The headers will appear in the include/ROOT/ML directory in the install tree - Python code - It contains the public API - Public functions appear under ROOT[.Experimental].ML module All public references to the name 'batch generator' are removed to avoid mixing responsibilities: RBatchGenerator is just the name of an internal class, which is never exposed to the user directly. Update tests and tutorials accordingly. Apply formatting changes to C++ and Python files. Add code owners to new directory.
vepadulano
force-pushed
the
dataloader-mv
branch
from
fa41ec4 to
3b88d38
Compare
vepadulano
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native ROOT data loading for ML training functionality is related to IO and
processing of structured data. It only depends on the ROOTDataFrame component.
As such, the following decisions have been made for this part of the codebase:
C++ code
Python code
All public references to the name 'batch generator' are removed to avoid mixing
responsibilities: RBatchGenerator is just the name of an internal class, which
is never exposed to the user directly.
Update tests and tutorials accordingly.
Apply formatting changes to C++ and Python files.
Add code owners to new directory.