Add tests for analytical TF1 integrals#21059
Closed
swetank18 wants to merge 2 commits intoroot-project:masterfrom
Closed
Add tests for analytical TF1 integrals#21059swetank18 wants to merge 2 commits intoroot-project:masterfrom
swetank18 wants to merge 2 commits intoroot-project:masterfrom
Conversation
Test Results2 497 tests 2 497 ✅ 1h 34m 44s ⏱️ Results for commit 5313756. |
hageboeck
requested changes
Jan 30, 2026
| const double a = 0.3; | ||
| const double b = 1.7; | ||
|
|
||
| const double result = f.AnalyticalIntegral(a, b); |
Member
There was a problem hiding this comment.
This does not compile. You need to include AnalyticalIntegral.h and construct an instance of the class. It would be best to test in a local build if the test compiles and passes.
Author
There was a problem hiding this comment.
Thanks for the clarification.
I’ve updated the tests to use the public TF1::Integral() interface and pushed the fix.
Member
|
This work continues in #21060 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Recent changes improved robustness of analytical TF1 integrals for edge cases
such as vanishing exponential slopes and invalid parameter domains.
Changes
Impact