Fix edge case in analytical integral of exponential TF1#20992
Closed
swetank18 wants to merge 2 commits intoroot-project:masterfrom
Closed
Fix edge case in analytical integral of exponential TF1#20992swetank18 wants to merge 2 commits intoroot-project:masterfrom
swetank18 wants to merge 2 commits intoroot-project:masterfrom
Conversation
hageboeck
requested changes
Jan 27, 2026
Member
hageboeck
left a comment
There was a problem hiding this comment.
Hello, thanks for the contribution!
The change looks reasonable. Could you run something like git clang-format HEAD~ on the commit? Otherwise, the CI will fail on the formatting checks.
Author
Thank you for the review. |
This was referenced Jan 29, 2026
Test Results 22 files 22 suites 3d 13h 19m 37s ⏱️ For more details on these failures, see this check. Results for commit 319674f. |
Member
|
The work here will be included in #21060 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The analytical integral for exponential TF1 functions does not handle the
p1 -> 0 limit and may result in division by zero or numerical instability.
Changes:
Impact: