[io] add test bed for streaming large objects#20608
[io] add test bed for streaming large objects#20608jblomer wants to merge 3 commits intoroot-project:Arlesiennefrom
Conversation
|
|
||
| namespace { | ||
|
|
||
| class FileRaii { |
There was a problem hiding this comment.
This can be pulled from ntuple_test.hxx, no?
There was a problem hiding this comment.
Yes, but perhaps just from the test support when the other PR is merged.
There was a problem hiding this comment.
I wanted to avoid including this large header here.
|
|
||
| char *buf = (char *)(fBuffer + cntpos); | ||
| if ((fBufCur - fBuffer - cntpos - sizeof(UInt_t)) >= kMaxMapCount) { | ||
| tobuf(buf, 0 | kByteCountMask); |
There was a problem hiding this comment.
The reason to write 0 | kByteCountMask is clear for us (today) but it might be confusing to anyone not familiar with the idea behind the plan; maybe a comment would help here.
There was a problem hiding this comment.
On the other hand, this code is already almost obsolete, i.e. replaced by #20574 (which is still missing a few wrinkles: decision on Reset behavior, getter and setter)
Fixes root-project#14770 [io] add more checks in TBuffer functions as suggested by jblomer
Uses RStreamerField as a test bed for (de-)serializing large objects with TBufferFile.
pcanal
force-pushed
the
io-large-buffer
branch
from
8be2fe3 to
e1f4b41
Compare
Test Results 22 files 22 suites 3d 22h 6m 46s ⏱️ For more details on these failures, see this check. Results for commit e1f4b41. |
4 participants
No description provided.