[ci] Set check_connection=OFF globally#19632
Merged
guitargeek merged 1 commit intoroot-project:masterfrom Aug 19, 2025
Merged
Conversation
guitargeek
changed the title
check_connection=ON globallycheck_connection=OFF globally
This way, we are not affected by problems downloading the connection check file from `root.cern`.
guitargeek
force-pushed
the
check_connection
branch
from
9846938 to
f7c9363
Compare
Contributor
|
Some tests are going to fail downloading files from root.cern if that server has issues. |
Contributor
Author
|
That's true, but at least it will actually build and run the tests 🙂 Thanks for having tried and fixed this flag, by the way! |
Test Results 21 files 21 suites 3d 10h 52m 48s ⏱️ Results for commit f7c9363. |
Member
|
thanks for this upgrade. Could this be documented in the 6.38 flags here https://root.cern/install/build_from_source/#all-build-options ? |
dpiparo
approved these changes
Aug 19, 2025
Contributor
Author
|
Sure! root-project/web#1143 |
Member
Do we still test |
Contributor
Author
|
No. But you're right, we should do it at least on one platform. I'll change that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, we are not affected by problems downloading the connection check file from
root.cern.