Conversation
Member
|
Guess I have been a bit overzealous, technically the |
Member
|
Thank you @VincentLanglet |
Member
|
Can you do the same for the https://github.com/rollerworks/PasswordStrengthBundle ? Thanks |
Contributor
Author
Sure, I opened rollerworks/PasswordStrengthBundle#121 Also what is your plan for the final 3.0.0 version ? :) |
sstok
added a commit
to rollerworks/PasswordStrengthBundle
that referenced
this pull request
Dec 17, 2025
This PR was merged into the 4.0-dev branch. Discussion ---------- | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Fixed tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT Same as rollerworks/PasswordStrengthValidator#74 Commits ------- bc5894b Keep support for SF 7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @sstok, while I appreciate you worked on SF8 support, #71
I feel like the support for SF 7 (and 6 ?) was dropped to fast.
Currently, when using Symfony 7.4 we have the choice between
All the (Breaking ?) changes you made for the 3.0.0 versions are still combatible with Symfony 7 ! (and symfony 6 too I think)
So you could keep at least 7.4 support.
Thanks for your consideration.