FIX: Only exclude directories when searching for tes3 plugins#35
Merged
rfuzzo merged 1 commit intorfuzzo:mainfrom May 8, 2025
Merged
FIX: Only exclude directories when searching for tes3 plugins#35rfuzzo merged 1 commit intorfuzzo:mainfrom
rfuzzo merged 1 commit intorfuzzo:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was speaking to a user in openmw discord who was trying my new vfstool, and they reported PLOX doesn't recognize collapsed directories at all: https://discord.com/channels/260439894298460160/995021436924203199/1368463129515917395
It seems as though plox just doesn't support links, maybe on accident, so I changed the filter here to omit directories instead of explicitly checking for a file. The rust docs seem to corroborate
is_filewill return false for link types on Windows, but I didn't look particularly close.