Add missing efm for TypeScript compiler#95
Open
mrousavy wants to merge 2 commits intoreviewdog:masterfrom
Open
Add missing efm for TypeScript compiler#95mrousavy wants to merge 2 commits intoreviewdog:masterfrom
mrousavy wants to merge 2 commits intoreviewdog:masterfrom
Conversation
haya14busa
requested changes
May 8, 2021
Comment on lines
+10
to
+11
| `%f(%l,%c): error TS%n: %m`, | ||
| `%f:%l:%c - error TS%n: %m`, |
|
@mrousavy Hi, is this PR still in progress? I would like to use this updated efm so that I can use it with |
Author
|
Hey, I haven't finished the work here, I think I'm using a different solution now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got this output when running on my local machine:
and on my CI it looked like this:
both of those didn't work with the current tsc, so this PR adds those.