feat: move private NodeEditor members for protected for extensibility

[samerickson]

Description

I have a unique issue where I want to use a pipe in the Editor to interrupt the nodecreate signal and only proceed with deleting the node if a certain criteria is not met. To support this workflow, I need to case to any, or copy and paste the whole NodeEditor into my project to swap this:

  /**
   * Add a node
   * @param data - The node data
   * @returns Whether the node was added
   * @throws If the node has already been added
   * @emits nodecreate
   * @emits nodecreated
   */
  async addNode(data: Scheme['Node']) {
    if (this.getNode(data.id)) throw new Error('node has already been added')

    if (!await this.emit({ type: 'nodecreate', data })) return false

    this.nodes.push(data)

    await this.emit({ type: 'nodecreated', data })
    return true
  }

For that:

  /**
   * Add a node
   * @param data - The node data
   * @returns Whether the node was added
   * @throws If the node has already been added
   * @emits nodecreate
   * @emits nodecreated
   */
  async addNode(data: Scheme['Node']) {
    if (!await this.emit({ type: 'nodecreate', data })) return false

    if (this.getNode(data.id)) throw new Error('node has already been added')

    this.nodes.push(data)

    await this.emit({ type: 'nodecreated', data })
    return true
  }

What I would like to be able to do is extend the NodeEditor class and override the addNode function, but with the nodes member being private, I have to cast this as any to do that.

Let me know if there is a better way to go about this, or if you are interested in moving more private members to protected, as there are a few other Rete plugins that I have similar interests in making private members protected for easier extensibility. I really like the Rete eco-system, keep up the great work!

Related Issues

N/A

Checklist

• I have read and followed the contribution guidelines.
• I have tested my changes locally.
• I have updated documentation accordingly (if necessary).
• I have added unit and E2E tests (if applicable).

Additional Notes

N/A

[Ni55aN]

If I've got this right, your goal is to mutate the graph within the nodecreate event. However, side effects are discouraged in such events, particularly when the side effect involves changes to the very entity triggering the event.

In any case, if you absolutely need to hook into this event, you can duplicate the trigger of nodecreate (perhaps using an extra flag to distinguish them) and call it before super.addNode