add support for before/after hooks to support tracing outbound requests#95
Closed
joshwilsdon wants to merge 3 commits intorestify:masterfrom
joshwilsdon:rfd-35-cls
Closed
add support for before/after hooks to support tracing outbound requests#95joshwilsdon wants to merge 3 commits intorestify:masterfrom joshwilsdon:rfd-35-cls
joshwilsdon wants to merge 3 commits intorestify:masterfrom
joshwilsdon:rfd-35-cls
Conversation
Member
|
@joshwilsdon Sorry for the radio silence on this. This feature is something we'd use and I'd like to see this merged before the 2.x release. A lot of movement has been occurring in this repo since you first opened this PR though, so it looks like it's a bit out of date. I'll take a shot at reconciling this against master to get it over the finish line. Appreciate the PR. |
Author
|
I don't know how I missed the update from @DonutEspresso but I was finally coming back to look at this and see that their PR is in better shape than mine at this point so closing this out in favor of #156. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds new options to the create*Client functions which allow before
and after hooks to be called for every request made by the client. This allows
for implementation of a tracing system around requests. It also allows a before
hook to add additional headers so that remote servers are provided tracing
information.
It replaces an earlier PR #77 which attempted to do the same
thing in a slightly different way.