fix: Allow following redirects that go to another server#213
Open
petercooperjr-spls wants to merge 1 commit intorestify:masterfrom
Open
fix: Allow following redirects that go to another server#213petercooperjr-spls wants to merge 1 commit intorestify:masterfrom
petercooperjr-spls wants to merge 1 commit intorestify:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For issue #212 allowing for redirects that go to another server.
This may not be the best approach, as I'm still quite new to node, but this fix solves the use case that caused me to find the problem. There may be other stuff that should be kept as well, like usernames/passwords on the URL. You're the experts, please feel free to adopt, adapt, or ignore this change.