-
Notifications
You must be signed in to change notification settings - Fork 908
feat(tailwind): Add css configs to Taliwind component
#2926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: canary
Are you sure you want to change the base?
Conversation
|
@JBezerra is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
|
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 6 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="playground/README.md">
<violation number="1" location="playground/README.md:11">
P3: Documentation path is inconsistent with the example and project structure; users are told to create `/emails` but templates live under `playground/emails`.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| ### 1. Create an email template | ||
|
|
||
| Create a new file at `playground/emails/testing.tsx` | ||
| Create a new file at `/emails` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: Documentation path is inconsistent with the example and project structure; users are told to create /emails but templates live under playground/emails.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At playground/README.md, line 11:
<comment>Documentation path is inconsistent with the example and project structure; users are told to create `/emails` but templates live under `playground/emails`.</comment>
<file context>
@@ -8,9 +8,9 @@ It includes all components directly from source with a path alias import of `@re
### 1. Create an email template
-Create a new file at `playground/emails/testing.tsx`
+Create a new file at `/emails`
-```tsx emails/testing.tsx
</file context>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, that's not perfectly right. I'm taking the fair assumption that is it obvious that root is playground given the README lives on it.
Along with this, I've removed testing.tsx because that was simply wrong given the phrase is "Create a new file at [...]"
Not sure of the process here, if this change should immediately bump the version. I leave this answer to @gabrielmfern. |
Summary
Adds support for CSS-based configuration to the
<Tailwind>component, aligning with Tailwind CSS v4's CSS-first approach.This addresses the discussion in #2863
Changes
themeandutilityprop toTailwindcomponentsetupTailwindto process custom CSS configurationsExample Usage (Using Vite)
Summary by cubic
Add CSS-first configuration to the Tailwind component with new theme and utility props. This brings Tailwind v4-style CSS configs while keeping support for the existing config prop.
Written for commit 4ab3e8a. Summary will update on new commits.