fix(contractor-onboarding) - pass employment_id to contract details to get the right schema#736
Closed
gabrielseco wants to merge 3 commits intomainfrom
Closed
fix(contractor-onboarding) - pass employment_id to contract details to get the right schema#736gabrielseco wants to merge 3 commits intomainfrom
gabrielseco wants to merge 3 commits intomainfrom
Conversation
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (283 total)
✅ Bundle size check passed |
Contributor
|
Deploy preview for remote-flows ready! ✅ Preview Built with commit 95f73c0. |
Contributor
|
Deploy preview for remote-flows-example-app ready! ✅ Preview Built with commit 95f73c0. |
Contributor
|
npm warn exec The following package was not found and will be installed: tsx@4.21.0 📊 Coverage Report⚪ Coverage unchanged
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
gabrielseco
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For COR we have a different contract_details schema, that's. why we need to pass the employment_id
Note
Low Risk
Small, localized change to schema-fetching parameters and query caching; primary risk is unintended cache misses or backend rejecting the new optional query parameter.
Overview
Contractor onboarding now includes the current
employment_idwhen fetching the contractorcontract_detailsJSON schema, and keys the React Query cache by bothcountryCodeandemploymentIdto avoid reusing the wrong schema across employments.The generated API types are updated to allow
employment_idas an optional query param forgetShowContractorContractDetailsCountry, and SDK docs/security metadata forgetShowFormCountryare refreshed (auto-generated changes).Written by Cursor Bugbot for commit 95f73c0. This will update automatically on new commits. Configure here.