Adapt global budget convergence criterion for runs with interalized damages#1988
Draft
laurinks wants to merge 1 commit intoremindmodel:developfrom
Draft
Adapt global budget convergence criterion for runs with interalized damages#1988laurinks wants to merge 1 commit intoremindmodel:developfrom
laurinks wants to merge 1 commit intoremindmodel:developfrom
Conversation
Contributor
Author
|
@orichters , @fpiontek : Here an implementation of Franziska's suggestion to remove the global budget convergence check for runs with internalized damages. I modified is slightly by only checking that the target budget is not exceeded, but allowing the actual budget to be lower. What do you think? |
Contributor
|
From my side, it looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Type of change
(Make sure to delete from the Type-of-change list the items not relevant to your PR)
Checklist:
remind2where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switcheslog.txtfile of my runs for newly introduced summation, fixing or variable name errorsFAIL 0in the output ofmake test)CHANGELOG.mdhas been updated correctlyFurther information (optional):