Open
Conversation
dktapps
requested changes
Jun 15, 2025
Collaborator
dktapps
left a comment
dktapps
left a comment
There was a problem hiding this comment.
Formatting is a disastrous mess, & looks like this also has multiple unrelated changes
dktapps
reviewed
Jun 15, 2025
Collaborator
dktapps
left a comment
dktapps
left a comment
There was a problem hiding this comment.
I feel like the code for cleaning up options, comparator etc seems to get repeated in a few different places. Probably worth making a function for it.
| zend_throw_exception(php_leveldb_ce_LevelDBException, err, 0); | ||
| leveldb_free(err); | ||
| return; | ||
| } |
Collaborator
There was a problem hiding this comment.
I'm not sure this is needed, I think the free_obj handler should take care of it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
make test TESTS=tests/022-block-cache.phptmake test TESTS=testshttps://chatgpt.com/codex/tasks/task_e_683fca06d404832785bd2dd1bf232737