Skip to content

Fix reopen cleanup in PHP LevelDB#52

Open
reeze wants to merge 1 commit intomasterfrom
codex/find-and-fix-a-bug-in-codebase
Open

Fix reopen cleanup in PHP LevelDB#52
reeze wants to merge 1 commit intomasterfrom
codex/find-and-fix-a-bug-in-codebase

Conversation

@reeze
Copy link
Owner

@reeze reeze commented Jun 4, 2025

Summary

  • ensure comparator and callable resources are released when reopening a DB
  • reset internal DB pointer to avoid double close
  • add regression test for reopening

Testing

  • make test TESTS=tests/021-reopen.phpt
  • make test TESTS=tests

https://chatgpt.com/codex/tasks/task_e_683fca06d404832785bd2dd1bf232737

@dktapps
Copy link
Collaborator

dktapps commented Jun 15, 2025

Looks OK although this is a pretty weird use case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants