Skip to content

Conversation

@pd-redis
Copy link
Contributor

@pd-redis pd-redis commented Jan 22, 2026

to disable runAsNode and remove afterPack script

What

It turns out that after v24 of electron-builder, fuses can be configured in the build json.

Testing

Package the app, then perform:

npx @electron/fuses read --app release/linux-arm64-unpacked/redisinsight

The result should be:

Analyzing app: redisinsight
Fuse Version: v1
  RunAsNode is Disabled
  EnableCookieEncryption is Disabled
  EnableNodeOptionsEnvironmentVariable is Enabled
  EnableNodeCliInspectArguments is Enabled
  EnableEmbeddedAsarIntegrityValidation is Disabled
  OnlyLoadAppFromAsar is Disabled
  LoadBrowserProcessSpecificV8Snapshot is Disabled
  GrantFileProtocolExtraPrivileges is Enabled

Note

Shifts Electron fuse configuration into build config and removes the custom post-packaging script, preserving existing behavior while simplifying packaging.

  • Configure electronFuses.runAsNode: false in electron-builder.json
  • Remove scripts/afterPack.js and the afterPack hook that previously flipped fuses
  • Update copyright year in electron-builder.json

Written by Cursor Bugbot for commit 59d754b. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2026

Code Coverage - Backend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 92.42% 13988/15136
🟡 Branches 74.42% 4280/5751
🟢 Functions 86.01% 2151/2501
🟢 Lines 92.23% 13375/14502

Test suite run success

3014 tests passing in 288 suites.

Report generated by 🧪jest coverage report action from 59d754b

Copy link
Contributor

@ArtemHoruzhenko ArtemHoruzhenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better then use scripts

@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2026

Code Coverage - Integration Tests

Status Category Percentage Covered / Total
🟢 Statements 81.51% 16351/20059
🟡 Branches 64.6% 7424/11491
🟡 Functions 70.4% 2289/3251
🟢 Lines 81.15% 15385/18958

@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2026

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 82.88% 21175/25549
🟡 Branches 68.17% 8953/13134
🟡 Functions 78.09% 5795/7421
🟢 Lines 83.27% 20736/24901

Test suite run success

5541 tests passing in 706 suites.

Report generated by 🧪jest coverage report action from 59d754b

valkirilov
valkirilov previously approved these changes Jan 22, 2026
KrumTy
KrumTy previously approved these changes Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants