Prevent ShareIntentTextRenderer from escaping chars from HTML#287
Merged
Shinokuni merged 1 commit intoreadrops:developfrom Jun 2, 2025
Merged
Prevent ShareIntentTextRenderer from escaping chars from HTML#287Shinokuni merged 1 commit intoreadrops:developfrom
Shinokuni merged 1 commit intoreadrops:developfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #287 +/- ##
=============================================
- Coverage 22.42% 22.42% -0.01%
Complexity 462 462
=============================================
Files 190 190
Lines 10206 10207 +1
Branches 1466 1466
=============================================
Hits 2289 2289
- Misses 7780 7781 +1
Partials 137 137 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
LGTM, could you just fix the conflict? |
christophehenry
force-pushed
the
fix-html-escape
branch
from
bb10955 to
723f345
Compare
Contributor
Author
|
Yep, done. |
christophehenry
force-pushed
the
fix-html-escape
branch
from
723f345 to
faaeb0a
Compare
christophehenry
force-pushed
the
fix-html-escape
branch
from
faaeb0a to
66346ea
Compare
Member
|
Thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix that I missed: the template engine is escaping characters for HTML. We don't want that behavior here.