feat: Add REST endpoints for icon library (facet, query, detail)#18
Open
adamjohnwright wants to merge 2 commits intomainfrom
Open
feat: Add REST endpoints for icon library (facet, query, detail)#18adamjohnwright wants to merge 2 commits intomainfrom
adamjohnwright wants to merge 2 commits intomainfrom
Conversation
Expose 3 new endpoints under /search/icon/ to support the Angular icon gallery page, matching the existing data-content IconLibraryController. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
EliotRagueneau
approved these changes
Feb 26, 2026
Contributor
EliotRagueneau
left a comment
EliotRagueneau
left a comment
There was a problem hiding this comment.
Looks good to me, ideally just add some tests as well for the new endpoints but totherwise okay :D
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
We have not added in very basic tests, but there are there! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose 3 new endpoints under /search/icon/ to support the Angular icon gallery page, matching the existing data-content IconLibraryController.
This was made by Claude Code with @el-rabies and me, telling it what to do. It is currently deployed on dev. https://dev.reactome.org/ContentService/