Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/KeyCode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -517,6 +517,26 @@ const KeyCode = {
return false;
}
},

isEditableTarget: function isEditableTarget(e: KeyboardEvent) {
const target = e.target;

if (!(target instanceof HTMLElement)) {
return false;
}

const tagName = target.tagName;
if (
tagName === 'INPUT' ||
tagName === 'TEXTAREA' ||
tagName === 'SELECT' ||
target.isContentEditable
) {
return true;
}

return false;
Comment on lines 529 to 538
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This conditional block can be simplified into a single return statement. This improves conciseness without sacrificing readability.

    return (
      e.isComposing ||
      tagName === 'INPUT' ||
      tagName === 'TEXTAREA' ||
      tagName === 'SELECT' ||
      target.isContentEditable
    );

},
};

export default KeyCode;
48 changes: 48 additions & 0 deletions tests/KeyCode.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
import KeyCode from '../src/KeyCode';
import { createEvent } from '@testing-library/react';

describe('KeyCode.isEditableTarget', () => {
it('check editable target', () => {
const eleList = [
{
element: 'window',
expected: false,
},
{
element: 'div',
expected: false,
},
{
element: 'input',
expected: true,
},
{
element: 'textarea',
expected: true,
},
{
element: 'select',
expected: true,
},
{
element: 'div',
isContentEditable: true,
expected: true,
},
];

eleList.forEach(({ element, isContentEditable, expected }) => {
const target =
element === 'window' ? window : document.createElement(element);
if (isContentEditable) {
// mock isContentEditable cause JSDOM don't support it
Object.defineProperty(target, 'isContentEditable', { value: true });
}
const event = createEvent.keyDown(target) as KeyboardEvent;
target.dispatchEvent(event);
const result = KeyCode.isEditableTarget(event);

expect(result).toBe(expected);
});
});
});
Loading