Closed
Conversation
Owner
|
Hey thanks for your interest! I will take a closer look this weekend, but offhand the right thing to do feels like to use the runtime page size where appropriate, and figure out a way to cast pointers without having the alignment be in type info. |
Merged
Owner
|
Wound up keeping the min page size in the alignment info as suggested, and changed over to use the real page size in actual size allocations. Thanks for the PR. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aside from the package manager changes, there's also how
page_sizeis no longer a comptime-known constant. I considered usingstd.heap.pageSize(), but given the page size is being used in type information, I went with the comptime-knownstd.heap.page_size_min.Not sure if
page_size_maxwould be better?