Merged
Conversation
* This change makes V128 operations treat stack values as 2 separate F64 values instead of taking up a single stack slot. The definition and instance still treat V128 types as single values, but the VM implementation and stack ops treat them as 2. * Smaller stack values have 2 advantages: 1. Speeding up the memcpy bottleneck when returning values from a function 2. Better cache coherency, fitting more stack space into a single cache line * Ops that previously operated on generic values, such as local ops, global ops, select, etc have been split into default (8-byte) and V128 (16 byte) versions that know the sizes of the stack values they need to manipulate. * Local indices, number of params, and number of return values now all have a fixup step where the values are adjusted according to the number of values a ValType occupies, where V128 values take 2, and the rest take 1.
Owner
Author
|
Closes #72 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.