Fix FImageView and FSkeletalMaterial compilation errors#1
Open
HarrisonHough wants to merge 7 commits intordeioris:masterfrom
Open
Fix FImageView and FSkeletalMaterial compilation errors#1HarrisonHough wants to merge 7 commits intordeioris:masterfrom
HarrisonHough wants to merge 7 commits intordeioris:masterfrom
Conversation
HarrisonHough
force-pushed
the
ImageView-fix
branch
from
fa3f86b to
81c6ada
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses 2 issues:
An FImageView compilation error, I couldn't find any reference to an FImageView in UE docs or code base. So I replaced the logic you see in TransientObjectSaverLibrary.cpp.
The SkeletalMaterial error is something that occurs on later versions of UE 5 (5.1+), an additional include is required to fix that.
Let me know if there are any edge cases or things that I have missed.