Skip to content

feat: export Preferences page as a component and consume it in apps/admin#1384

Open
paanSinghCoder wants to merge 9 commits intofeat/export-webhooks-pagefrom
feat/export-preferences-page
Open

feat: export Preferences page as a component and consume it in apps/admin#1384
paanSinghCoder wants to merge 9 commits intofeat/export-webhooks-pagefrom
feat/export-preferences-page

Conversation

@paanSinghCoder
Copy link
Contributor

@paanSinghCoder paanSinghCoder commented Feb 16, 2026

Move preferences to lib

Summary

  • Moved preferences from apps/admin/src/containers/preferences.list to lib/admin/views/preferences using git mv.
  • Lib: Single PreferencesView (same pattern as RolesView/ProductsView/WebhooksView): fetches preferences + traits, and renders either the list or the detail form based on selectedPreferenceName. No <Outlet />; list and details live inside the view.
  • App: PreferencesPage matches other admin pages: one page for /preferences and /preferences/:name, passing selectedPreferenceName and onCloseDetail into PreferencesView. Removed PreferencesLayout, PreferencesList, and PreferenceDetails from app routes.
  • Columns: “Edit” uses <Link to={\/preferences/${name}`}>` (same approach as plans and admins in lib).
  • Result: Preferences live in lib, are exported as PreferencesView, and are used from the app in the same way as roles, products, and webhooks.

@vercel
Copy link

vercel bot commented Feb 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Feb 19, 2026 9:50am

@coderabbitai
Copy link

coderabbitai bot commented Feb 16, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@paanSinghCoder paanSinghCoder self-assigned this Feb 16, 2026
@paanSinghCoder paanSinghCoder added the Do not merge Label to indicate that the PR is not ready to be merged even though might be (or not) approvals. label Feb 16, 2026
@paanSinghCoder paanSinghCoder changed the title feat: export preferences page feat: export Preferences page as a component and consume it in apps/admin Feb 16, 2026
@coveralls
Copy link

coveralls commented Feb 16, 2026

Pull Request Test Coverage Report for Build 22176745829

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 38.457%

Totals Coverage Status
Change from base Build 22176671941: 0.0%
Covered Lines: 16200
Relevant Lines: 42125

💛 - Coveralls

@paanSinghCoder paanSinghCoder requested a review from rsbh February 16, 2026 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do not merge Label to indicate that the PR is not ready to be merged even though might be (or not) approvals.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments