feat: export admin page as a component and consume it in apps/admin#1375
Open
paanSinghCoder wants to merge 57 commits intomainfrom
Open
feat: export admin page as a component and consume it in apps/admin#1375paanSinghCoder wants to merge 57 commits intomainfrom
paanSinghCoder wants to merge 57 commits intomainfrom
Conversation
…ent and related files
…ctionality in admin UI
…I to use new views structure
Base automatically changed from
feat/export-audit-logs-page
to
feat/export-products-page
February 16, 2026 06:23
Base automatically changed from
feat/export-products-page
to
feat/export-invoices-page
February 16, 2026 06:23
Base automatically changed from
feat/export-invoices-page
to
refactor/admin-ui-child
February 16, 2026 06:24
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
web/apps/admin/vite.config.ts (1)
3-41:⚠️ Potential issue | 🟡 MinorResolve
react-router-domvia Node resolution to avoid workspace layout coupling.The hard-coded
node_modules/react-router-dompath assumes a specific install layout; with pnpm's symlink-based resolution, this can be fragile across different setups. The similar vite config inweb/apps/client-demodoesn't use this alias and resolves the package without issue—consider whether the alias is necessary. If it must be retained, use dynamic resolution (e.g.,createRequire(...).resolve) instead of relying on a hard-coded path.💡 Suggested fix (portable alias resolution)
import react from "@vitejs/plugin-react-swc"; import dotenv from "dotenv"; import path from "path"; import { fileURLToPath } from "url"; +import { createRequire } from "module"; import { defineConfig } from "vite"; import tsconfigPaths from "vite-tsconfig-paths"; import svgr from "vite-plugin-svgr"; dotenv.config(); const __dirname = path.dirname(fileURLToPath(import.meta.url)); +const require = createRequire(import.meta.url); +const reactRouterDomPath = path.dirname( + require.resolve("react-router-dom/package.json") +); resolve: { alias: { - "react-router-dom": path.resolve(__dirname, "node_modules/react-router-dom"), + "react-router-dom": reactRouterDomPath, }, },
rsbh
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/admin/src/containers/super_admins/tolib/admin/views/admins/usinggit mvto preserve history.AdminsViewfrom@raystack/frontier/adminas a router-agnostic view (same behavior: list platform users + service users, client-side table, "Super Admins" header).AdminsPagewrapper inapps/adminthat renders<AdminsView />.super-adminsroute to useAdminsPage; route path and behavior unchanged.Test plan
/organizations/:orgId.pnpm buildinweb/lib.pnpm buildinweb/apps/admin.