Skip to content

Conversation

@joshdimanteto
Copy link

@joshdimanteto joshdimanteto commented Jan 7, 2026

This PR will close #520

Description

  • Update pydantic to version 2
  • Change field_validator that are use repetitively to use annotated pattern

Testing Instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check GitHub Actions build
  • If icatdb Generator Script Consistency Test CI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?
  • Review changes to test coverage
  • Does this change mean a new patch, minor or major version should be made? If so, does one of the commit messages feature fix:, feat: or BREAKING CHANGE: so a release is automatically made via GitHub Actions upon merge?
  • {more steps here}

Agile Board Tracking

Connect to #520

@joshdimanteto joshdimanteto force-pushed the upgrade-to-pydantic-V2-#520 branch from fa97c48 to b9fbab0 Compare January 8, 2026 16:43
@joshdimanteto joshdimanteto force-pushed the upgrade-to-pydantic-V2-#520 branch from 4548eb9 to f5a8fbf Compare January 8, 2026 17:29
@joshdimanteto joshdimanteto force-pushed the upgrade-to-pydantic-V2-#520 branch 3 times, most recently from 7284f0d to 9f8c259 Compare January 9, 2026 12:14
@joshdimanteto joshdimanteto force-pushed the upgrade-to-pydantic-V2-#520 branch from 9f8c259 to 06c6be2 Compare January 9, 2026 14:55
@joshdimanteto joshdimanteto marked this pull request as ready for review January 14, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants