remove database backend #489 #507
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdimanteto
changed the title
joshdimanteto
changed the title
joshdimanteto
force-pushed
the
remove-database-backend-#489
branch
from
5e5d6c4 to
743b34b
Compare
joshdimanteto
force-pushed
the
remove-database-backend-#489
branch
4 times, most recently
from
86a347f to
c3a28c4
Compare
joshdimanteto
force-pushed
the
remove-database-backend-#489
branch
from
c3a28c4 to
2939010
Compare
joshdimanteto
force-pushed
the
remove-database-backend-#489
branch
from
e1afd0a to
34d2603
Compare
- remove downgrade of setuptools
Added `# noqa: B907` in several places where manual quoting is required for valid SQL query syntax. Using `!r` would change the format and break query parsing, so explicit quotes are necessary. This ensures tests and API calls remain correct while satisfying linting requirements.
- In the test_query_filter_factory the test don't work on the CI as it is not setting up the db backend.
joshdimanteto
changed the base branch from
main
to
remove-older-python-versions-#517
joshdimanteto
force-pushed
the
remove-older-python-versions-#517
branch
from
04a2567 to
8673a50
Compare
joshdimanteto
force-pushed
the
remove-database-backend-#489
branch
from
94aad25 to
e280471
Compare
joshdimanteto
commented
Nov 17, 2025
joshdimanteto
force-pushed
the
remove-database-backend-#489
branch
from
9ac04a6 to
84b9f59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will close #489
Description
Remove the database backend functionality from the DataGateway API. It includes significant changes such as deleting database-related files and functionality, updating tests to remove database dependencies, and modifying the configuration to align with the changes.
Testing Instructions
Add a set up instructions describing how the reviewer should test the code
icatdb Generator Script Consistency TestCI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?fix:,feat:orBREAKING CHANGE:so a release is automatically made via GitHub Actions upon merge?Agile Board Tracking
Connect to #489
notes
The icat models still use SQLAlchemy, this is going to be update in the pydantic V2 upgrade to use pydantic