Conversation
Replace with py3-compatible `in` statements
This version of range is an iterator, eliminating the need for xrange, which is not present in py3
py3 map() returns an iterator, so an explicit call to list() is added here.
Explicit call to list() to convert values() call from iterator
Open
Owner
|
Thanks for taking the time to make these updates for Python 3! (Sorry for the late response.) I'm a bit swamped now with other projects, but I'll make sure to do some efficiency tests and merge, as soon as possible. |
|
I know I can simply use the fork, but in this day and age it would be nice to have official python 3 support. |
|
@rajanil Any movement on this? |
|
It's been a while since this was first posted. It would be great to have Python3 support, as Python2 has been deprecated for some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple minor updates to support Python3. (Fix Issue #23)
Most changes are to the handling of print statements, but there are also some changes to support changes in string processing (namely the separation of strings and bytes) in python 3.
Tested under both Python3 and Python2, so all changes should be backward compatible. There should not be any major changes to efficiency, but I have not benchmarked.