Fix filtering on root folder and add filtering tests#90
Open
anthonyraymond wants to merge 1 commit intoradovskyb:masterfrom
Open
Fix filtering on root folder and add filtering tests#90anthonyraymond wants to merge 1 commit intoradovskyb:masterfrom
anthonyraymond wants to merge 1 commit intoradovskyb:masterfrom
Conversation
dideler
added a commit
to dideler/watcher
that referenced
this pull request
Apr 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filtering was only applied to the element inside the watched path, but it was not applied to the watched path himself.
I've added a test to prevent regression and i've also added some more test about filtering.