Fix race condition in retrieveFileList()#115
Open
Botono wants to merge 1 commit intoradovskyb:masterfrom
Open
Conversation
… the mutex, allowing the retrieveFileList method use a single lock.
xiaoyang-chen
pushed a commit
to xiaoyang-chen/file-watcher
that referenced
this pull request
Aug 14, 2025
…adovskyb/watcher#115 for panic interface{} conversion and race condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been getting a
fatal error: sync: unlock of unlocked mutexwhen using the package in my setup, although I have not been able to reproduce it in isolation yet. However, implementing this change fixes the panic.Unlocking the mutex inside of a locking method introduces a race condition. This change creates private methods that do the operations of the
Remove()andRemoveRecursive()methods, but without the mutex locks. This allowsretrieveFileList()to call them without unlocking the mutex first.Remove()andRemoveRecursive()are then updated to call the private methods instead of doing the processing themselves.