Skip to content

Conversation

@hadley
Copy link
Member

@hadley hadley commented Sep 29, 2025

  • Don't need to force RStudio project creation if in positron
  • Make it easier to install the dev dependencies

The second bullet is the most important here — I realised that 100% of the time I call create_from_github() the next function I call is pak::pak() in order to be able to actually run the tests. I think this is probably generally true, and installing a few extra packages shouldn't be harmful.

* Don't need to force RStudio project creation if in positron
* Make it easier to install the dev dependencies
@hadley hadley requested a review from jennybc September 29, 2025 13:00
@hadley
Copy link
Member Author

hadley commented Sep 30, 2025

I'm finding the auto-install super helpful as I work through the testthat revdeps.

Copy link
Member

@DavisVaughan DavisVaughan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of these feel like wins to me for normal day to day usage of this function

I have definitely gotten in the habit of having to clear out RStudio specific info when I use create_from_github() from Positron on a non-RStudio project, so that feels like a win.

Notably, I do not think I would have used install_dependencies for my Claude Code adventures with dplyr revdeps. I specifically wanted to control the libpath where the dependencies were installed to, so I had to:

  • create_from_github() to make pkg/
  • Add pkg/.Rprofile which added a custom path to .libPaths()
  • Then pak::pak()

So I would have needed to inject a step in the middle there.

But that's a rare use case, and I would still have been able to achieve this because I would have been able to just set install_dependencies = FALSE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants