Include file names in challenge_uncommited_changes()#2001
Open
olivroy wants to merge 17 commits intor-lib:mainfrom
Open
Include file names in challenge_uncommited_changes()#2001olivroy wants to merge 17 commits intor-lib:mainfrom
challenge_uncommited_changes()#2001olivroy wants to merge 17 commits intor-lib:mainfrom
Conversation
challenge_uncommited_changes()
challenge_uncommited_changes()challenge_uncommited_changes()
Member
|
I think this is a good pattern to reuse in this scenario: This is ultimately coming from |
87cd0e9 to
54e13c1
Compare
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof of concept to make the message shorter, and more focused on current situation.
Adding a
whichargument that conflicts withmsg.Rephrase message to be shorter.
Add a link to the uncommited files with
{.file.format_inline()will shorten automatically as needed.I think it is worth adding files in the message, since it can facilitate the choice.
Let me know what you think!
This PR:
Before
Yields the following message (instead of the correctly formatted with ! before.