feat(api): add support for verses/by_range endpoint#44
Open
basit3407 wants to merge 1 commit intoquran:mainfrom
Open
feat(api): add support for verses/by_range endpoint#44basit3407 wants to merge 1 commit intoquran:mainfrom
basit3407 wants to merge 1 commit intoquran:mainfrom
Conversation
This commit adds support for the new `/api/v4/verses/by_range` endpoint to the JS SDK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the new
GET /api/v4/verses/by_rangeendpoint to the JS SDK, allowing consumers to fetch verses within a specific range of verse keys (e.g.,'1:1'to'1:7').It also ensures the Tafsir type definition is up-to-date with the latest
quran.com-apichanges, including new fields for tafsir grouping and localization.Changes
languageIdgroupVerseKeyFromgroupVerseKeyTogroupTafsirIdstartVerseIdendVerseId/api/v4/verses/by_rangeto support local testing.Verification
pnpm testand validated all tests pass, including the new findByRange test cases. for the new/api/v4/verses/by_rangeendpoint to the JS SDK.