Fix -Wnontrivial-memcall #483
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The user-defined copy assignment operator made the type non-trivially copyable and just copied x with a self-assignment check, even though the copy constructor is defaulted. Since the struct only contains a single uint16_t, this diff defaults the copy assignment operator and fixes the
-Wnontrivial-memcallwarning introduced when building with llvm 21.(fyi: This is code clean up - the flag
-Wnontrivial-memcallis planned on being disabled anyways for nowT251075049)