Skip to content

Conversation

@novak-vaclav
Copy link
Contributor

@novak-vaclav novak-vaclav commented Jan 12, 2026

Summary

adds support for "Squeeze" operator

Test plan

tests can be manually run using pytest -c /dev/null backends/nxp/tests/

cc @robert-kalmar @MartinPavella

Copilot AI review requested due to automatic review settings January 12, 2026 13:14
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 12, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16540

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 20bf3f1 with merge base 7793b1d (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 12, 2026
@novak-vaclav
Copy link
Contributor Author

@pytorchbot label "release notes: nxp"

@novak-vaclav
Copy link
Contributor Author

@pytorchbot label "module: nxp"

@pytorch-bot pytorch-bot bot added the release notes: nxp Changes to the NXP Neutron backend delegate label Jan 12, 2026
@pytorch-bot pytorch-bot bot added the module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ label Jan 12, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for the "Squeeze" operator in the NXP backend by implementing a pass that converts squeeze operations to view operations.

Changes:

  • Added ConvertSqueezeToViewPass class that transforms aten.squeeze operations into aten.view operations
  • Integrated the new pass into NeutronAtenPassManager
  • Added SqueezeAddModel test model and comprehensive test suite covering various squeeze scenarios

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
backends/nxp/aten_passes/convert_squeeze_to_view.py Implements the pass to convert squeeze operations to view operations, following the same pattern as the existing unsqueeze pass
backends/nxp/aten_passes/neutron_aten_pass_manager.py Integrates ConvertSqueezeToViewPass into the pass manager and updates copyright year
backends/nxp/tests/models.py Adds SqueezeAddModel test helper class for testing squeeze operations
backends/nxp/tests/test_convert_squeeze_to_view.py Comprehensive test suite covering squeeze with None dim, specific dims, negative dims, lists/tuples, and partial/full dimension overlaps

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@novak-vaclav novak-vaclav force-pushed the feature/EIEX-673-add-support-for-squeeze-operator branch from 67fb8ba to ebf1adc Compare January 12, 2026 13:57
Copy link
Collaborator

@MartinPavella MartinPavella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from not combining this pass with convert_unsqeeze_to_view, LGTM

Copilot AI review requested due to automatic review settings January 13, 2026 12:09
@novak-vaclav novak-vaclav force-pushed the feature/EIEX-673-add-support-for-squeeze-operator branch from ebf1adc to 22c7a9d Compare January 13, 2026 12:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@novak-vaclav novak-vaclav force-pushed the feature/EIEX-673-add-support-for-squeeze-operator branch from 22c7a9d to 6b59feb Compare January 13, 2026 12:26
@MartinPavella
Copy link
Collaborator

LGTM. Just please fix the linting.

Copilot AI review requested due to automatic review settings January 13, 2026 14:18
@novak-vaclav novak-vaclav force-pushed the feature/EIEX-673-add-support-for-squeeze-operator branch from 6b59feb to dc91ae9 Compare January 13, 2026 14:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@novak-vaclav novak-vaclav force-pushed the feature/EIEX-673-add-support-for-squeeze-operator branch from dc91ae9 to 20bf3f1 Compare January 13, 2026 14:24
@novak-vaclav
Copy link
Contributor Author

Hopefully fixed all the issues, but one Bamboo test is failing. Already working on it, please wait before merging @MartinPavella

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants