Pre-commit: disable autofix PR's, ignore E203,W503#194
Merged
Conengmo merged 2 commits intopython-visualization:mainfrom Mar 16, 2025
Merged
Pre-commit: disable autofix PR's, ignore E203,W503#194Conengmo merged 2 commits intopython-visualization:mainfrom
Conengmo merged 2 commits intopython-visualization:mainfrom
Conversation
Member
|
Yeah, we should not use autofix. That was probably a copy-n-pasta from when I added the config file. |
ocefpaf
approved these changes
Mar 16, 2025
Member
Author
|
I reckon they switched the default on their side, because it didn’t use to be an issue. thanks for the review btw! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While developing I struggled with the autofix PR's from Pre-commit. It lead to merge conflicts on every push and much frustration. I think it's better to disable it.
I had an other issue also, where Flake8 and Black were disagreeing on a style aspect. Flake8 should ignore two aspects that Black enforces. We may switch to Ruff in the future, but for now just ignore them.
These changes are needed to merge #193.
:https://www.flake8rules.com/rules/E203.html