fix: handle tz-aware datetimes in naturalday and naturaldate#297
Open
bysiber wants to merge 1 commit intopython-humanize:mainfrom
Open
fix: handle tz-aware datetimes in naturalday and naturaldate#297bysiber wants to merge 1 commit intopython-humanize:mainfrom
bysiber wants to merge 1 commit intopython-humanize:mainfrom
Conversation
When a tz-aware datetime is passed to naturalday() or naturaldate(), the date comparison should use 'today' in the datetime's timezone rather than the system's local date. Previously the timezone was stripped and the date compared against dt.date.today(), which could yield wrong results (e.g. returning 'tomorrow' when the local date in the given timezone is actually the same day). Fixes python-humanize#152
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #152
When a tz-aware datetime is passed to
naturalday()ornaturaldate(), the functions now compute "today" in the datetime's timezone instead of using the system's local date.For example, if the current UTC time is
2023-10-15 23:00and you pass a datetime in AEDT (+11:00) where the local date is already Oct 16th, the comparison should use Oct 16th as "today" for that timezone. Previously the timezone was stripped and compared against the system local date, which gave wrong results when the tz-local date differed from the system date.The fix checks whether the value is a tz-aware datetime and, if so, calls
datetime.now(value.tzinfo).date()instead ofdate.today(). The existing behavior for naive datetimes and plaindateobjects is unchanged.Test included using the exact scenarios from the issue.