Add https support for monit collector.#543
Open
nesoneg wants to merge 3 commits intopython-diamond:masterfrom
nesoneg:master
Open
Add https support for monit collector.#543nesoneg wants to merge 3 commits intopython-diamond:masterfrom nesoneg:master
nesoneg wants to merge 3 commits intopython-diamond:masterfrom
nesoneg:master
Conversation
Member
|
Can you fix the pep8 errors? also update the doc and testing? |
src/collectors/monit/monit.py
Outdated
| self.config['host'], | ||
| int(self.config['port'])) | ||
|
|
||
| if self.config['selfsigned'] and sys.hexversion >= 0x020709f0 and hasattr(ssl, '_create_unverified_context'): |
Member
There was a problem hiding this comment.
Can you add a comment as to what version 0x020709f0 correlates to? or use sys.version_info instead?
More compliance PEP8 format source code. Domumentation update.
Author
|
I update doc and bit more accurate PEP8. |
| metrics_blacklist | None | Regex to match metrics to block. Mutually exclusive with metrics_whitelist | NoneType | ||
| metrics_whitelist | None | Regex to match metrics to transmit. Mutually exclusive with metrics_blacklist | NoneType | ||
| send_totals | False | Send cpu and memory totals | bool | ||
| scheme | http | Select scheme http or https | str |
Member
There was a problem hiding this comment.
The descriptions need to be added to the get_default_config_help method in the collector file since this doc is actually generated from that.
Member
|
1 pep8 error left For testing, PR540 would be a good reference for the scheme checking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use private methods, but worked.