pybricks.connections.pybricks: Clear halt on endpoints instead of resetting device. #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etting device. Change how we ensure the USB endpoints are in a good state when connecting to a device. Instead of resetting the device, which is not supported on all platforms, we now clear the halt condition on both endpoints. We were doing the reset to ensure that the even/odd data toggle state was correct. The reset, if supported, would completely reset the connection and re-enumerate the device, which is more that we need. On Windows, resetting is not supported and libusb would poke all endpoints like this as a best-effort approximation of a reset. So now, the code reflects what is actually important and will be helpful if we switch to something other than pyusb in the future.
dlech
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change how we ensure the USB endpoints are in a good state when connecting to a device. Instead of resetting the device, which is not supported on all platforms, we now clear the halt condition on both endpoints.
We were doing the reset to ensure that the even/odd data toggle state was correct. The reset, if supported, would completely reset the connection and re-enumerate the device, which is more that we need. On Windows, resetting is not supported and libusb would poke all endpoints like this as a best-effort approximation of a reset. So now, the code reflects what is actually important and will be helpful if we switch to something other than pyusb in the future.