This repository was archived by the owner on Jan 16, 2024. It is now read-only.
Fix conflicts with apps using multiple engines#50
Open
ashervb wants to merge 1 commit intopushtype:masterfrom
Open
Fix conflicts with apps using multiple engines#50ashervb wants to merge 1 commit intopushtype:masterfrom
ashervb wants to merge 1 commit intopushtype:masterfrom
Conversation
Contributor
|
Hi thanks for the PR, and sorry for keeping you waiting. I currently can't merge this. The patch was originally introduced so that kaminari could be used in both pushtype and the main app - discussed here kaminari/kaminari#322. I think your PR will reintroduce that issue. It seems what we actually need is something like: begin
@template.push_type_admin.url_for arguments
rescue
begin
base_page_url_for(page)
rescue
@template.main_app.url_for arguments
end
end... even if that is the ugliest code I've ever written |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If routes are being pulled in via another Engine, the
map_app.url_forcan fail resulting in aActionController::UrlGenerationErrorerror