Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
============================================
- Coverage 75.93% 75.77% -0.16%
Complexity 279 279
============================================
Files 33 33
Lines 2418 2423 +5
Branches 112 113 +1
============================================
Hits 1836 1836
- Misses 527 532 +5
Partials 55 55
Continue to review full report at Codecov.
|
hc0503
approved these changes
Nov 4, 2020
Contributor
|
Hi. I want to fix the underlying issue (possibly by just merging this), but looking at the current code and the java-websocketclient, I'm not sure this is needed anymore. It seems that setting the proxy and the socketFactory should be enough. Could you confirm that the current code in master is not enough? EDIT: closed by mistake. Reopened |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the pull request
... Fix bug #99. This is essentially the same code as PR #176, but it updates the code to work with the version of java_websocket by using WebSocketImpl.DEFAULT_WSS_PORT instead of WebSocket.DEFAULT_WSS_PORT.
Why is the change necessary?
... To fix bug #99
CC @pusher/mobile